This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Merged
Conversation
Contributor
|
@blkt great, thank you, can you take this out of draft so we can ack and merge? I'll add a similar utility to the cursor provider, just an inline copy for now, and once we refactor we can merge the two. |
This change adds a utility routine to dump raw data tapped from the wire to multiple files in a temporary directory under the path specified via `CODEGATE_DUMP_DIR`. No instrumentation is performed if `CODEGATE_DUMP_DIR` is `None`. The temporary directory is not deleted when the process exits. NOTE: the utility does not ensure the folder specified via `CODEGATE_DUMP_DIR` is writable, which might cause user-visible failures at startup. Co-authored-by: Radoslav Dimitrov <[email protected]>
blkt
force-pushed
the
chore/add-dump-request-utilities
branch
from
e3bbc63 to
e432e54
Compare
jhrozek
reviewed
Jan 24, 2025
| @@ -1,6 +1,10 @@ | |||
| import asyncio | |||
| import contextlib | |||
jhrozek
approved these changes
Jan 24, 2025
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
I'm not sure about contextlib, but otherwise looks good
lukehinds
pushed a commit
that referenced
this pull request
Jan 31, 2025
This change adds a utility routine to dump raw data tapped from the wire to multiple files in a temporary directory under the path specified via `CODEGATE_DUMP_DIR`. No instrumentation is performed if `CODEGATE_DUMP_DIR` is `None`. The temporary directory is not deleted when the process exits. NOTE: the utility does not ensure the folder specified via `CODEGATE_DUMP_DIR` is writable, which might cause user-visible failures at startup. Co-authored-by: Radoslav Dimitrov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a utility routine to dump raw data tapped from the wire to multiple files in a temporary directory under the path specified via
CODEGATE_DUMP_DIR.No instrumentation is performed if
CODEGATE_DUMP_DIRisNone. The temporary directory is not deleted when the process exits.NOTE: the utility does not ensure the folder specified via
CODEGATE_DUMP_DIRis writable, which might cause user-visible failures at startup.